feat(context-menu): add context menu to dashboard #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 4 alerts when merging 9541f435e621711e865ba63e01aca1448e1b664f into 1c1c9dd - view on LGTM.com new alerts:
|
jmbuss
force-pushed
the
feat/dashboard-context-menu
branch
3 times, most recently
from
b013bcc to
d01396c
Compare
diehbria
requested changes
Aug 15, 2022
packages/dashboard/src/integration/iot-dashboard-context-menu.spec.component.ts
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-internal.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-messages/messages.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-messages/messages.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-messages/messages.ts
Outdated
Show resolved
Hide resolved
jmbuss
force-pushed
the
feat/dashboard-context-menu
branch
2 times, most recently
from
3edf6ca to
1aa6727
Compare
diehbria
reviewed
Aug 16, 2022
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-context-menu-option.tsx
Outdated
Show resolved
Hide resolved
diehbria
reviewed
Aug 16, 2022
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-dashboard-context-menu.tsx
Outdated
Show resolved
Hide resolved
diehbria
reviewed
Aug 16, 2022
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-dashboard-context-menu.tsx
Outdated
Show resolved
Hide resolved
jmbuss
force-pushed
the
feat/dashboard-context-menu
branch
4 times, most recently
from
3bd6cd0 to
931422c
Compare
diehbria
requested changes
Aug 17, 2022
packages/dashboard/src/components/iot-dashboard/iot-context-menu/contextMenuOptions.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-context-menu-option.css
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-context-menu-option.css
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-context-menu-section.css
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-dashboard-context-menu.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-internal.tsx
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-messages/messages.ts
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-messages/messages.ts
Outdated
Show resolved
Hide resolved
jmbuss
force-pushed
the
feat/dashboard-context-menu
branch
2 times, most recently
from
cdc0c21 to
7267de5
Compare
diehbria
requested changes
Aug 18, 2022
packages/dashboard/src/components/iot-dashboard/iot-context-menu/iot-context-menu.css
Outdated
Show resolved
Hide resolved
packages/dashboard/src/components/iot-dashboard/iot-dashboard-internal.tsx
Outdated
Show resolved
Hide resolved
jmbuss
force-pushed
the
feat/dashboard-context-menu
branch
from
7267de5 to
8ca5f95
Compare
diehbria
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a right click context menu to the dashboard. The contents of which are defined by
getContextMenuConfigurationinpackages/dashboard/src/components/iot-dashboard/iot-dashboard-internal.tsx. The positioning of the menu to handled through the popperjs library. This ensures that the popper will stay on screen no matter where you right click.This also introduces a message overrides configuration for the dashboard. Right now this includes the text for the context menu and fallback messaging for a dashboard widget that has failed to load.
Tests
[Include a link to the passing GitHub action running the test suite here.]
Legal
This project is available under the Apache 2.0 License.